Add basic benchmark scheduler #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 25, 2024
This patch introduces the BenchmarkScheduler interface that sets the CPU affinity mask for the current process and gets a benchmark core for use by llvm-exegesis. This patch additional introduces a BenchmarkScheduler implementation that simply does nothing, which will preserve the behavior that we have currently where we do not explicitly set CPU masks. Pull Request: google#270
ondrasej
requested changes
Dec 30, 2024
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 30, 2024
This patch introduces the BenchmarkScheduler interface that sets the CPU affinity mask for the current process and gets a benchmark core for use by llvm-exegesis. This patch additional introduces a BenchmarkScheduler implementation that simply does nothing, which will preserve the behavior that we have currently where we do not explicitly set CPU masks. Pull Request: google#270
ondrasej
approved these changes
Dec 30, 2024
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch introduces the BenchmarkScheduler interface that sets the CPU affinity mask for the current process and gets a benchmark core for use by llvm-exegesis. This patch additional introduces a BenchmarkScheduler implementation that simply does nothing, which will preserve the behavior that we have currently where we do not explicitly set CPU masks. Pull Request: google#270
Created using spr 1.3.4
boomanaiden154
changed the base branch from
users/boomanaiden154/main.add-basic-benchmark-scheduler
to
main
boomanaiden154
deleted the
users/boomanaiden154/add-basic-benchmark-scheduler
branch
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This reverts commit 86a1c06. I apparently accidentally fixed up google#271 into google#270. This reverts the changes that accidentally made there way into the tree. Pull Request: google#276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the BenchmarkScheduler interface that sets the CPU
affinity mask for the current process and gets a benchmark core for use
by llvm-exegesis. This patch additional introduces a BenchmarkScheduler
implementation that simply does nothing, which will preserve the
behavior that we have currently where we do not explicitly set CPU
masks.