core/app/crash: Fix a crash in the crash handler

If the crash report fails to send, we'd end up taking down the entire server. As reported in #1580.
google · Feb 13, 2018 · 2f5a49d · 2f5a49d
1 parent 32473ae
commit 2f5a49d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/app/crash/reporting/reporting.go b/core/app/crash/reporting/reporting.go
@@ -104,7 +104,9 @@ func (r Reporter) sendReport(body io.Reader, contentType, endpoint string) (stri
 
 	client := &http.Client{}
 	res, err := client.Do(req)
-	defer res.Body.Close()
+	if err == nil {
+		defer res.Body.Close()
+	}
 	if err != nil || res.StatusCode != http.StatusOK {
 		return "", fmt.Errorf("Failed to upload report request: %v (%v)", err, res.StatusCode)
 	}