Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linefont: removed latin subsets #6864

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Linefont: removed latin subsets #6864

merged 1 commit into from
Oct 17, 2023

Conversation

RosaWagner
Copy link
Contributor

because we disable subsetting for that font.
Would unblock #4630

@github-actions
Copy link

FontBakery report

fontbakery version: 0.10.1

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wdth-wght', 1) [code: summary]


[23] Linefont[wdth,wght].ttf
💔 ERROR: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
  • 💔 ERROR Failed with TypeError: 'NoneType' object is not subscriptable
🔥 FAIL: METADATA.pb should contain at least "menu" and "latin" subsets. (com.google.fonts/check/metadata/menu_and_latin)
  • 🔥 FAIL Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin". [code: missing]
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Linefont") does not match correct font name format ("Linefont Thin"). [code: mismatch]
🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Normal wdth 100.0 2 None 100.0 2 None
SemiExpanded wdth 112.5 0 None 112.5 0 None
Expanded wdth 125.0 0 None 125.0 0 None
ExtraExpanded wdth 150.0 0 None 150.0 0 None
UltraExpanded wdth 200.0 0 None 200.0 0 None
SuperCondensed wdth 25.0 0 None 25.0 0 None
UltraCondensed wdth 50.0 0 None 50.0 0 None
ExtraCondensed wdth 62.5 0 None 62.5 0 None
Condensed wdth 75.0 0 None 75.0 0 None
SemiCondensed wdth 87.5 0 None 87.5 0 None
Thin wght 100.0 0 None 100.0 0 None
ExtraLight wght 200.0 0 None 200.0 0 None
Light wght 300.0 0 None 300.0 0 None
Regular wght 400.0 2 700.0 400.0 2 700.0
Medium wght 500.0 0 None 500.0 0 None
SemiBold wght 600.0 0 None 600.0 0 None
Bold wght 700.0 0 None 700.0 0 None
ExtraBold wght 800.0 0 None 800.0 0 None
Black wght 900.0 0 None 900.0 0 None
ExtraBlack wght 1000.0 0 None N/A N/A N/A
[code: bad-axis-values]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL On the font variation axis 'wght', the name 'ExtraBlack' is not among the expected ones (Thin, ExtraLight, Light, Regular, Medium, SemiBold, Bold, ExtraBold, Black) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1283, but got 1200 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value should be equal or greater than 1271, but got 200 instead [code: descent]
🔥 FAIL: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • 🔥 FAIL The '.notdef' glyph should contain a drawing, but it is blank. [code: notdef-is-blank]
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0009 : try adding symbols

  • U+000A : try adding symbols

  • U+000B : try adding symbols

  • U+000C : try adding symbols

  • U+0085 : try adding symbols

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext

  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext

  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext

  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext

  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
    185 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu [code: unreachable-subsetting]

WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font:

    • Contour 0 start point differs in glyph 'pos.9' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'pos.10' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'neg.2' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'pos.3' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'neg.3' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'pos.8' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'neg.10' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'pos.7' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'pos.4' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • Contour 0 start point differs in glyph 'neg.4' between location wdth=100,wght=100 and location wdth=25,wght=1000

    • 8 more.

Use -F or --full-lists to disable shortening of long lists. [code: interpolation-issues]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN _15 is composed of a single component and therefore could not be checked. Please check manually. [code: single-component]
  • WARN _61 is composed of a single component and therefore could not be checked. Please check manually. [code: single-component]
  • WARN _62 is composed of a single component and therefore could not be checked. Please check manually. [code: single-component]
  • WARN _101 is composed of a single component and therefore could not be checked. Please check manually. [code: single-component]
WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • _1 (U+0030): X=44.0,Y=-0.5 (should be at baseline 0?)

    • _1 (U+0030): X=44.0,Y=-0.5 (should be at cap-height 0?)

    • _1 (U+0030): X=50.0,Y=-2.0 (should be at baseline 0?)

    • _1 (U+0030): X=50.0,Y=-2.0 (should be at cap-height 0?)

    • _1 (U+0030): X=56.0,Y=-0.5 (should be at baseline 0?)

    • _1 (U+0030): X=56.0,Y=-0.5 (should be at cap-height 0?)

    • _1 (U+0061): X=44.0,Y=-0.5 (should be at baseline 0?)

    • _1 (U+0061): X=44.0,Y=-0.5 (should be at cap-height 0?)

    • _1 (U+0061): X=50.0,Y=-2.0 (should be at baseline 0?)

    • _1 (U+0061): X=50.0,Y=-2.0 (should be at cap-height 0?)

    • 13 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/linefont/Linefont[wdth,wght].ttf
Dehinted Size 131.2kb
Hinted Size 131.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.002;gftools[0.9.33]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.002;gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/linefont [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
1 6 8 50 9 178 0
0% 2% 3% 20% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 280644f into main Oct 17, 2023
9 checks passed
@RosaWagner RosaWagner deleted the linefont-subsets branch October 17, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant