-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtree pull Axis Registry introducing YELA
#6358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding [YALN] Y Alignment custom Axis
@RosaWagner added it to the old good Traffic Jam. Let me know if it should be differently now. |
Dave has a concern about the type of axis (if it should be an absolute range per-mile). So blocking it until we review it again tomorrow. |
RosaWagner
changed the title
Subtree pull Axis Registry introducing
Subtree pull Axis Registry introducing Jun 14, 2023
YALN
YELA
RosaWagner
reviewed
Jun 14, 2023
axisregistry/Lib/axisregistry/data/y_element_alignment.textproto
Outdated
Show resolved
Hide resolved
RosaWagner
added
-- Needs confirmation
from upstream or onboarder
and removed
--- blocked
labels
Jun 14, 2023
vv-monsalve
added
- Ready for Review
and removed
-- Needs confirmation
from upstream or onboarder
labels
Jun 14, 2023
Axis was renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YALN - Vertical Alignment
axis required by WavefontThis PR should navigate through the pipeline simultaneously with #6185