Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VF fonts for Homecomputer #2223

Closed
wants to merge 6 commits into from

Conversation

jenskutilek
Copy link

Work in progress, I know it has some errors in fontbakery.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 29, 2019

Thanks!

Unfortunately we don't support VFs with multiple axes just yet. I'll still take a look but we'll probably release it next year.

@davelab6
Copy link
Member

Thank you @jenskutilek!! :)

@davelab6 davelab6 added this to the Add New Families milestone Nov 18, 2019
Base automatically changed from master to main February 26, 2021 16:09
@RosaWagner
Copy link
Contributor

In order to onboard these fonts, we would need 1 directory per family in ofl + a correction of the copyright string in the OFL.txt + fixing the fontbakery fails.

@jenskutilek are you still working on this? do you still want to onboard these fonts?

@RosaWagner RosaWagner added -- Needs confirmation from upstream or onboarder and removed -- Needs manager's opinion from upper level labels Apr 8, 2021
@jenskutilek
Copy link
Author

Hi @RosaWagner, yes I'll be happy to continue. I'll have time in the coming weeks, don't know exactly when yet.

@RosaWagner RosaWagner added -- Upstream is working on it Designer is making changes in the upstream repo and removed -- Needs confirmation from upstream or onboarder labels Apr 14, 2021
@RosaWagner
Copy link
Contributor

@jenskutilek awesome !
These days we are using gftools builder to build the fonts. Texturina is a good example of use and workflow. Don't hesitate if you need more info to match the spec.

@jenskutilek jenskutilek changed the title WIP: Add VF fonts for Homecomputer Add VF fonts for Homecomputer Jul 8, 2021
@jenskutilek
Copy link
Author

@RosaWagner I've adapted the upstream repo and build process, I think it's getting somewhere.

Can you have a look? The upstream is at https://github.com/jenskutilek/homecomputer-fonts

@RosaWagner RosaWagner added - Ready for Review -- Requires Axis Registration Variable axes are not yet registered and removed -- Upstream is working on it Designer is making changes in the upstream repo labels Jul 15, 2021
@RosaWagner RosaWagner linked an issue Jul 15, 2021 that may be closed by this pull request
7 tasks
@RosaWagner
Copy link
Contributor

I think it would be preferable to have separated PRs for the two fonts.
Let's discuss the axes and related STAT table (fallback position and name) in the dedicated issue :)

Fontbakery report

Fontbakery version: 0.7.37

[1] Family checks
🔥 FAIL: Do we have the latest version of FontBakery installed?

[16] Sixtyfour[BLED,SCAN].ttf
💔 ERROR: Check METADATA.pb font weights are correct.
--- Rationale ---
Check METADATA.pb font weights are correct.
For static fonts, the metadata weight should be the same as the static font's
OS/2 usWeightClass.
For variable fonts, the weight value should be 400 if the font's wght axis range
includes 400, otherwise it should be the value closest to 400.
  • 💔 ERROR Failed with NameError: name 'f' is not defined
🔥 FAIL: Check license file has good copyright string.
--- Rationale ---
An OFL.txt file's first line should be the font copyright e.g:
"Copyright 2019 The Montserrat Project Authors
(https://github.com/julietaula/montserrat)"
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
--- Rationale ---
The expected pattern for the copyright string adheres to the following rules:
* It must say "Copyright" followed by a 4 digit year (optionally followed by a
hyphen and another 4 digit year)
* Then it must say "The <familyname> Project Authors"
* And within parentheses, a URL for a git repository must be provided
* The check is case insensitive and does not validate whether the familyname is
correct, even though we'd expect it is (and we may soon update the check to
validate that aspect as well!)
Here is an example of a valid copyright string:
"Copyright 2017 The Archivo Black Project Authors
(https://github.com/Omnibus-Type/ArchivoBlack)"
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "copyright 2021 jens kutilek (https://github.com/jenskutilek/homecomputer-fonts). all rights reserved." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: METADATA.pb: Check font name is the same as family name.
🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry.
--- Rationale ---
Check that particle names and values on STAT table match the fallback names in
each axis entry at the Google Fonts Axis Registry, available at
https://github.com/google/fonts/tree/main/axisregistry
  • 🔥 FAIL On the font variation axis 'ital', the name 'Regular' is not among the expected ones (Roman, Italic) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Validate VF axes match the ones declared on METADATA.pb.
--- Rationale ---
All font variation axes present in the font files must be properly declared on
METADATA.pb so that they can be served by the GFonts API.
  • 🔥 FAIL The font variation axes BLED and SCAN are present in the font's fvar table but are not declared on the METADATA.pb file. [code: missing-axes]
🔥 FAIL: Ensure variable fonts include an avar table.
--- Rationale ---
Most variable fonts should include an avar table to correctly define axes
progression rates.
For example, a weight axis from 0% to 100% doesn't map directly to 100 to 1000,
because a 10% progression from 0% may be too much to define the 200, while 90%
may be too little to define the 900.
If the progression rates of axes is linear, this check can be ignored. Fontmake
will also skip adding an avar table if the progression rates are linear.
However, we still recommend designers visually proof each instance is at the
desired weight, width etc.
  • 🔥 FAIL This variable font does not have an avar table. [code: missing-avar]
🔥 FAIL: Check glyphs do not have components which are themselves components.
--- Rationale ---
There have been bugs rendering variable fonts with nested components.
Additionally, some static fonts with nested components have been reported to
have rendering and printing issues.
For more info, see:
* https://github.com/googlefonts/fontbakery/issues/2961
* https://github.com/arrowtype/recursive/issues/412
  • 🔥 FAIL The following glyphs have components which themselves are component glyphs:
    • Aacute
    • Aacute
    • Acircumflex
    • Acircumflex
    • Adieresis
    • Adieresis
    • Agrave
    • Agrave
    • Aring
    • Aring and 142 more. [code: found-nested-components]
WARN: DESCRIPTION.en_us.html should end in a linebreak.
--- Rationale ---
Some older text-handling tools sometimes misbehave if the last line of data in a
text file is not terminated with a newline character (also known as '\n').
We know that this is a very small detail, but for the sake of keeping all
DESCRIPTION.en_us.html files uniformly formatted throughout the GFonts
collection, we chose to adopt the practice of placing this final linebreak char
on them.
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: License URL matches License text on name table?
--- Rationale ---
A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.
The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).
The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."
Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.
When in doubt, please choose OFL for new font projects.
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
--- Rationale ---
Traditionally version 0 'gasp' tables were set so that font sizes below 8 ppem
had no grid fitting but did have antialiasing. From 9-16 ppem, just grid
fitting. And fonts above 17ppem had both antialiasing and grid fitting toggled
on. The use of accelerated graphics cards and higher resolution screens make
this approach obsolete. Microsoft's DirectWrite pushed this even further with
much improved rendering built into the OS and apps.
In this scenario it makes sense to simply toggle all 4 flags ON for all font
sizes.
  • WARN The gasp range 0xFFFF value 0x0A should be set to 0x0F. [code: unset-flags]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?
  • com.google.fonts/check/metadata/designer_profiles

  • WARN It seems that Jens Kutilek is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
1 10 6 54 8 125 0
0% 5% 3% 26% 4% 61% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@RosaWagner RosaWagner removed this from the Add New Families milestone Aug 13, 2021
@RosaWagner RosaWagner removed a link to an issue Oct 20, 2021
7 tasks
@RosaWagner
Copy link
Contributor

I close this cause we will do separate PR with gftools packager anyway

@RosaWagner RosaWagner closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Requires Axis Registration Variable axes are not yet registered I New Font
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants