Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete @NullableDecl #173

Closed
wants to merge 1 commit into from
Closed

Replace obsolete @NullableDecl #173

wants to merge 1 commit into from

Conversation

olekw
Copy link

@olekw olekw commented Jun 30, 2020

From downstream fix in Debian.

Fix for #172

From downstream fix in Debian.
@kluever kluever requested a review from cpovirk July 1, 2020 13:27
@kluever kluever added P3 type=enhancement Make an existing feature better labels Jul 1, 2020
@olekw
Copy link
Author

olekw commented Jul 15, 2020

This is currently not building correctly because of old code in Google Bazel Common. Once a pending PR is accepted, a build against Google Bazel Common HEAD should succeed.

@olekw
Copy link
Author

olekw commented Jul 21, 2020

As an alternative, you could also manually define workspace rules instead of loading the clearly very outdated ones from the google_bazel_common project.

@cpovirk
Copy link
Member

cpovirk commented Aug 15, 2024

We finally migrated off @NullableDecl and onto the JSpecify annotations (which we added to bazel-common) in #384.

@cpovirk cpovirk closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes P3 type=enhancement Make an existing feature better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants