Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Philosophy links, update copyright year, #4283

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Philosophy links, update copyright year, #4283

wants to merge 1 commit into from

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 10, 2024 •
edited
Loading

Small fixes to the Flax website.

Change the copyright year to 2024.

index.rst: Fixing the Philosophy URL

-The Flax philosophy <philosophyhttps://flax.readthedocs.io/en/latest/philosophy.html>
+ The Flax philosophy <https://flax.readthedocs.io/en/latest/philosophy.html>

@8bitmp3 8bitmp3 self-assigned this Oct 10, 2024
cgarciae
cgarciae reviewed Oct 10, 2024
View reviewed changes
docs_nnx/conf.py
@@ -113,7 +113,7 @@
# href with no underline and white bold text color
announcement = """
<a
href="https://flax-linen.readthedocs.io/en/latest"
href="https://flax.readthedocs.io/en/latest"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to link to flax-linen here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it @cgarciae

Local builds seem fine even before the changes in this PR. ReadTheDocs' builds have the strange redirect for Glossary. As @IvyZX suggested maybe it's the redirect in the RTD config.

As discussed, will also rename the file to nnx_glossary.rst and see if that makes a difference.

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 10, 2024

Addressing Glossary-related issues and other improvements in #4284

@8bitmp3 8bitmp3 changed the title Fix Flax Glossary and Philosophy links, update copyright year, make Checkpointing guide non-executable Fix Philosophy links, update copyright year, Oct 10, 2024
@8bitmp3 8bitmp3 marked this pull request as draft October 10, 2024 23:36
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 22, 2024

#4313 fixes the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae left review comments

@IvyZX IvyZX Awaiting requested review from IvyZX

At least 1 approving review is required to merge this pull request.

Assignees

@8bitmp3 8bitmp3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8bitmp3 @cgarciae