Error example generator #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a program that generates examples of erroneous parses, along with some information about the potential errors, with the intention of allowing developers to quickly find out what states do *not* have associated error messages. Ideally, this program would be used to check that there *are no* states that are missing error messages, but actually adding all of those messages is not feasible right now: at this change, enumerate_parse_errors finds 5808 states that are missing messages.
|
This is an update of a PR from some time in 2023 which I never actually finished, which, itself, is an update of an internal CL from 2015(!) that was approved but never actually checked in, so... it may be a little bit disjointed. It's also pretty algorithmically subtle. I have tried to document it, but I am not confident that I was able to make it clear. |
This is a program that generates examples of erroneous parses, along with some information about the potential errors, with the intention of allowing developers to quickly find out what states do *not* have associated error messages. Ideally, this program would be used to check that there *are no* states that are missing error messages, but actually adding all of those messages is not feasible right now: at this change, enumerate_parse_errors finds 5808 states that are missing messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a program that generates examples of erroneous parses, along
with some information about the potential errors, with the intention of
allowing developers to quickly find out what states do not have
associated error messages.
Ideally, this program would be used to check that there are no states
that are missing error messages, but actually adding all of those
messages is not feasible right now: at this change,
enumerate_parse_errors finds 5808 states that are missing messages.