Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function call syntax for builtin functions #18

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

mcy
Copy link
Contributor

@mcy mcy commented Jun 14, 2021

This commit paves the way to adding crypto primitives to the surface
language, such as SIGN(), for painlessly generating signed data, esp. for
testing X.509 parsers.

@google-cla google-cla bot added the cla: yes label Jun 14, 2021
@mcy mcy force-pushed the vars branch 4 times, most recently from 120a80e to 40301a7 Compare July 2, 2021 02:08
@mcy
Copy link
Contributor Author

mcy commented Jul 2, 2021

I've dropped another commit on the stack to implement sign(). =)

Note that I don't really have a good unit testing story because I couldn't think of one I was happy with. Maybe I should just call executeBuiltin() directly from a builtins_test.go?

@mcy
Copy link
Contributor Author

mcy commented Feb 22, 2022

For simplicity, this is now based on #22. Only the last three commits are worth looking at (or we could wait until libraryfication is done, too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants