Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for returning empty String if no ALPN extension was read #1005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaoh
Copy link

@kaoh kaoh commented Apr 18, 2021

The Java SSLEngine
defines three states: null, an empty response and a string for the application protocol. getApplicationProtocol returns just null or or value. If no ALPN is found an empty string must be returned.

This fixes issue #1003

@koh-osug
Copy link

The build system has configuration issues. It reports:

Error: /home/runner/work/conscrypt/conscrypt/common/src/test/java/org/conscrypt/java/security/cert/CertificateFactoryTest.java:799: warning: [JdkObsolete] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.

for the original unchanged code.

@kaoh kaoh closed this Apr 18, 2021
@kaoh kaoh reopened this Apr 18, 2021
@kaoh kaoh closed this Apr 20, 2021
@kaoh kaoh reopened this Apr 20, 2021
@kaoh
Copy link
Author

kaoh commented Apr 20, 2021

Local builds are working but remotely the ubuntu task always fails with a timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants