Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar: refresh translation #2211

Merged
merged 2 commits into from
Jul 12, 2024
Merged

ar: refresh translation #2211

merged 2 commits into from
Jul 12, 2024

Conversation

younies
Copy link
Member

@younies younies commented Jul 9, 2024

No description provided.

Copy link
Collaborator

@henrif75 henrif75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @younies,
The .po file has a big diff, because the comments with file names have the line number.
Did you try to extract the messages.pot file with the granularity parameter set to 0?

MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot", "granularity": 0}}' \
  mdbook build -d po

@mgeisler mgeisler changed the title Port all the content for Arabic translation ar: refresh translation Jul 10, 2024
@younies
Copy link
Member Author

younies commented Jul 10, 2024

Hi @younies, The .po file has a big diff, because the comments with file names have the line number. Did you try to extract the messages.pot file with the granularity parameter set to 0?

MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot", "granularity": 0}}' \
  mdbook build -d po

@henrif75 , yes, I have done this :)

@younies younies requested a review from henrif75 July 10, 2024 13:19
@henrif75
Copy link
Collaborator

henrif75 commented Jul 10, 2024

Hi @younies, The .po file has a big diff, because the comments with file names have the line number. Did you try to extract the messages.pot file with the granularity parameter set to 0?

MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot", "granularity": 0}}' \
  mdbook build -d po

@henrif75 , yes, I have done this :)

That's funny. It's not the first time that happens. Can you check one more thing, which version of the gettext tools do you have installed?

For reference, I ran the command and updated the ar.po file (added .txt to be able to upload)
ar.po.txt

Finally, check this comment as well.

@younies
Copy link
Member Author

younies commented Jul 11, 2024

eck thi

@henrif75

interesting, here is my version

gettext (GNU gettext-runtime) 0.22.5
Copyright (C) 1995-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Ulrich Drepper.

@younies
Copy link
Member Author

younies commented Jul 11, 2024

Hi @henrif75,

I have created this PR (#2216) to show the difference in gettext file generation.

I am not sure why there is a big difference.

and this pr from linux #2218

@henrif75
Copy link
Collaborator

I noticed that in this last commit the file format is correct, have you done anything differently?

@henrif75 henrif75 merged commit a62d665 into google:main Jul 12, 2024
69 checks passed
@younies younies deleted the arabic-translation branch July 12, 2024 09:36
@younies
Copy link
Member Author

younies commented Jul 12, 2024

I noticed that in this last commit the file format is correct, have you done anything differently?

@henrif75 , no , I just copied the file that you have generated.

@henrif75
Copy link
Collaborator

I noticed that in this last commit the file format is correct, have you done anything differently?

@henrif75 , no , I just copied the file that you have generated.

As a last request, could you check which version of mdbook you're using?
mdbook --version
I'll open an issue to investigate what's going on.
Thanks for your patience.

@carreter
Copy link
Contributor

FYI, fix for this is now up in a PR: google/mdbook-i18n-helpers#215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants