Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CSS files into theme/ folder #1229

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Move CSS files into theme/ folder #1229

merged 1 commit into from
Sep 21, 2023

Conversation

hmn53
Copy link
Contributor

@hmn53 hmn53 commented Sep 21, 2023

Hi all,
This PR fixes #1226:

  • Moved CSS files to theme/css
  • Moved speaker-notes.js to theme/
  • Updated paths in book.toml

@hmn53
Move CSS files into theme/ folder
ad18ae4 
* Moved CSS files from root to `theme/css`
* Moved speaker-notes.js from root to `theme/`
* Updated paths in book.toml
mgeisler
mgeisler approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I downloaded one of the artifacts from https://github.com/google/comprehensive-rust/actions/runs/6259275059 and checked it locally — it looks like everything works just fine.

Thanks!

@mgeisler mgeisler merged commit cc0a78e into google:main Sep 21, 2023
@mgeisler
Copy link
Collaborator

Hi @hmn53, thanks for this! I guess you got things working locally to verify that it looks okay after the move?

If so, could I get you to submit the CSS rules here in theme/svgbob.css to the upstream project? I think they belong there and I opened boozook/mdbook-svgbob#22 a long time ago as a reminder to myself 😄

@mgeisler
Copy link
Collaborator

I'm also a committer on the svgbob project, so I can help with the review there.

@hmn53
Copy link
Contributor Author

hmn53 commented Sep 21, 2023

Hey @mgeisler, I verified the changes locally and they're working fine.

For the issue boozook/mdbook-svgbob#22, will we have the css rules inside the styles attribute in svgbob.rs?

@mgeisler
Copy link
Collaborator

Hey @mgeisler, I verified the changes locally and they're working fine.

Thanks! It's all live now and it looks great!

For the issue boozook/mdbook-svgbob#22, will we have the css rules inside the styles attribute in svgbob.rs?

I honestly don't know the project super well, but from a quick glance that looks correct. I don't see any other CSS in the project. Perhaps it comes from the svgbob library used? Let's discuss in the other bug! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move CSS files into theme/ folder
2 participants
@hmn53 @mgeisler