Convert double to integer via truncation. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches behavior of C, Go, and Java. Introduce a round() function for round-half-away like GoogleSQL.
doc/langdef.md
Outdated
| @@ -2070,7 +2070,8 @@ See [cel-go/issues/9](https://github.com/google/cel-go/issues/9). | |||
| (double) -> int | |||
| </td> | |||
| <td> | |||
| type conversion | |||
| Type conversion. Rounds toward zero, then errors if result is out of | |||
| range. See also round(). | |||
There was a problem hiding this comment.
Let's introduce round, floor, and ceil into a math namespace in a separate PR.
e.g. math.round(double), etc.
Defer round() until another PR.
|
PTAL |
|
Filed Issue #193 as a reminder to implement the math extension library with alternate ways of rounding. |
TristonianJones
approved these changes
Jun 2, 2021
sthagen
added a commit
to sthagen/google-cel-spec
that referenced
this pull request
Jul 16, 2021
Convert double to integer via truncation. (google#192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches behavior of C, Go, and Java.
Introduce a round() function for round-half-away like GoogleSQL.
Fixes #191