Cisco: Change ip protocol to be ipv4 not ip if using object-groups in…

… the cisco generator.

CiscoXR started supporting only:
  permit ipv4 ....

no longer do they supoprt:
  permit ip ....

past version 7.5 (probably? data on when this stopped working is murky.)

PiperOrigin-RevId: 584962959

capirca/lib/cisco.py

@@ -832,7 +832,12 @@ def __str__(self):
 
     # protocol
     if not self.term.protocol:
-      protocol = ['ip']
+      if self.af == 6:
+        protocol = ['ipv6']
+      elif self.platform == 'ciscoxr':
+        protocol = ['ipv4']
+      else:
+        protocol = ['ip']
 
     else:
       protocol = [proto if proto in self.ALLOWED_PROTO_STRINGS

tests/lib/ciscoxr_test.py

@@ -328,6 +328,12 @@ def testVerbatimObjectGroup(self):
     acl = ciscoxr.CiscoXR(pol, EXP_INFO)
     self.assertIn('permit tcp any', str(acl))
 
+  def testObjectGroup(self):
+    self.naming.GetNetAddr.return_value = [nacaddr.IP('10.1.1.1/32')]
+    pol = policy.ParsePolicy(OBJECT_GROUP_HEADER + GOOD_TERM_4, self.naming)
+    acl = ciscoxr.CiscoXR(pol, EXP_INFO)
+    self.assertIn('permit ipv4  any', str(acl))
+
 
 if __name__ == '__main__':
   absltest.main()