Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATT improvements #90

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

GATT improvements #90

wants to merge 1 commit into from

Conversation

uael
Copy link
Contributor

@uael uael commented Nov 29, 2022

No description provided.

@@ -712,7 +712,7 @@ async def read_characteristics_by_uuid(self, uuid, service):
logger.warning(f'bogus handle value: {attribute_handle}')
return []

characteristics_values.append(attribute_value)
characteristics_values.append((attribute_handle, attribute_value))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a comment /doc on the method to explain that what's returned is a list of (handle, value) pairs now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add a type to function definition so mypy can catch any mismatched usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants