Convert HCI role and transport into enums #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
reviewed
Nov 15, 2023
bumble/core.py
Outdated
| BT_CENTRAL_ROLE = Role.CENTRAL | ||
| BT_PERIPHERAL_ROLE = Role.PERIPHERAL | ||
|
|
||
| class Transport(enum.IntEnum): |
There was a problem hiding this comment.
I'd recommend naming this TransportType, not to confuse with the Transport object from bumble.transport.common
There was a problem hiding this comment.
How about BtTransport?
There was a problem hiding this comment.
Maybe PhysicalTransport, since that's the term used in the BT spec?
bumble/core.py
Outdated
Comment on lines
38
to
45
|
|
||
| BT_CENTRAL_ROLE = Role.CENTRAL | ||
| BT_PERIPHERAL_ROLE = Role.PERIPHERAL | ||
|
|
||
| BT_BR_EDR_TRANSPORT = PhysicalTransport.BR_EDR | ||
| BT_LE_TRANSPORT = PhysicalTransport.LE | ||
|
|
There was a problem hiding this comment.
what is the reason for these defines? could they be removed?
There was a problem hiding this comment.
That's for backward compatibility. There have been an significant usage of these primitive constants, so removing them here will be irresponsible.
As they are widely used as parameters, making them enums can significantly improve the static check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they are widely used as parameters, making them enums can significantly improve the static check.