Skip to content

Commit

Permalink
Merge pull request #7859 from BeksOmega/fix/previewer-disposing
Browse files Browse the repository at this point in the history
fix: connection previewer disposing too early
(cherry picked from commit da3ec25)
  • Loading branch information
maribethb committed Feb 15, 2024
1 parent 592c541 commit f4961f6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion core/block_dragger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,6 @@ export class BlockDragger implements IBlockDragger {

blockAnimation.disconnectUiStop();
this.connectionPreviewer.hidePreview();
this.connectionPreviewer.dispose();

const preventMove =
!!this.dragTarget_ &&
Expand Down Expand Up @@ -417,6 +416,9 @@ export class BlockDragger implements IBlockDragger {
);
}
}
// Must dispose after `updateBlockAfterMove_` is called to not break the
// dynamic connections plugin.
this.connectionPreviewer.dispose();
this.workspace_.setResizesEnabled(true);

eventUtils.setGroup(false);
Expand Down

0 comments on commit f4961f6

Please sign in to comment.