Update client to accommodate oauth2client>=4.0 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houglum
reviewed
Nov 15, 2017
| self._GetServiceCreds(service_account_name='my_service_account', | ||
| scopes=scopes) | ||
| self._GetServiceCreds(service_account_name=None, | ||
| scopes=None) |
There was a problem hiding this comment.
Did the linter not complain about the odd spacing here (and the statement below)?
There was a problem hiding this comment.
It did, I've added a fix in the latest test. How about I squash this all
There was a problem hiding this comment.
Sounds good. That's the only nit I had -- LGTM if you're addressing that :)
This changes has been needed for a while now. The main blocker seems to be the use of locked_file for caching GCE credentials. I've added a simple multiprocess lockable file cache that uses a similar approach to that used in ouath2client's multiprocess file storage. Submission of this should close issue #162.
houglum
approved these changes
Nov 15, 2017
|
I ran the gsutil integration tests, both on a clean clone of gsutil, and on a clone where I substituted my apitools repo into the third_party directory. The change introduced no new failures (although 2 unit tests and one integration test seemed to be already failing in the unaltered repo). |
|
Just ran the gsutil integration tests with this apitools fork against:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes has been needed for a while now. The main blocker
seems to be the use of locked_file for caching GCE credentials.
I've added a simple multiprocess lockable file cache that uses
a similar approach to that used in ouath2client's multiprocess
file storage.
Submission of this should close issue #162.