Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to accommodate support for oauth2client>4.0.0 #162

Open
samdeepk opened this issue May 11, 2017 · 3 comments
Open

Update to accommodate support for oauth2client>4.0.0 #162

samdeepk opened this issue May 11, 2017 · 3 comments

Comments

@samdeepk
Copy link

cloudendpoints/endpoints-management-python#21
@samdeepk
Copy link
Author

Any update on this.?

@samdeepk
Copy link
Author

from oauth2client import locked_file
ImportError: cannot import name locked_file

we have upgraded oauth2client an year ago, this library is still using an year old version of that package. This dependencies are holding us back for migrating to endpoints v2, for which the V1 is already deprecated. It would be great if dependencies from Google managed libraries are compatible with other Google libraries.

@samdeepk samdeepk changed the title Is there chance update to accommodate oauth2client>4.0.0 Update to accommodate support for oauth2client>4.0.0 Oct 26, 2017
@eap eap mentioned this issue Nov 15, 2017
Merged
craigcitro pushed a commit that referenced this issue Nov 16, 2017
@eap @craigcitro
Update client to accommodate oauth2client>=4.0 (#184)
63e97c1 
This changes has been needed for a while now. The main blocker
seems to be the use of locked_file for caching GCE credentials.
I've added a simple multiprocess lockable file cache that uses
a similar approach to that used in ouath2client's multiprocess
file storage.

Submission of this should close issue #162.
craigcitro pushed a commit that referenced this issue Nov 17, 2017
@eap @craigcitro
Close out the rest of oauth compatibility issues (#186)
cbf9c60 
* Update client to accommodate oauth2client>=4.0

This changes has been needed for a while now. The main blocker
seems to be the use of locked_file for caching GCE credentials.
I've added a simple multiprocess lockable file cache that uses
a similar approach to that used in ouath2client's multiprocess
file storage.

Submission of this should close issue #162.

* Update test runner setup
@fili
Copy link

fili commented Feb 26, 2018

It actually also impacts endpoints and apitools for another reason:

/apitools/base/py/credentials_lib.py", line 71, in <module>
    from oauth2client import multistore_file
ImportError: cannot import name multistore_file

Could only find this solution (which is to downgrade): https://stackoverflow.com/a/44266031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fili @samdeepk