Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the DateType value in the demo app. #2723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2720

Description
The demo app crashed when LocalDate parsing was attempted on valueString of DateType (e.g., '1966').
Fix: LocalDate is now parsed from DateType.value instead of valueString.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle santosh-pingle marked this pull request as ready for review November 15, 2024 09:57
@santosh-pingle santosh-pingle requested a review from a team as a code owner November 15, 2024 09:57
@MJ1998
Copy link
Collaborator

MJ1998 commented Nov 15, 2024

What is the issue with

LocalDate parsing was attempted on valueString of DateType (e.g., '1966').

?

@santosh-pingle
Copy link
Collaborator Author

What is the issue with

LocalDate parsing was attempted on valueString of DateType (e.g., '1966').

?
its partial date value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Demo app crashes when searching patient which has invalid date.
2 participants