Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling Database Access in FHIR Patch Generation #2683

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Oct 1, 2024

To ensure all database operations originate from the FhirEngineImpl class, the synchronization functions should be refactored. Instead of directly accessing the database within the PatchGenerator class, the lambda functions used in the synchronization process should be modified to accept a List<LocalChangeResourceReference> object as input. This list will contain references to the resources that require synchronization, allowing FhirEngineImpl to handle the necessary database interactions.

This approach centralizes database access in FhirEngineImpl, improving code organization and maintainability.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@MJ1998 MJ1998 requested a review from a team as a code owner October 1, 2024 12:13
@MJ1998 MJ1998 requested a review from aditya-07 October 1, 2024 12:13
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Thanks!

@jingtang10 jingtang10 enabled auto-merge (squash) October 11, 2024 11:59
@jingtang10 jingtang10 merged commit e702d60 into google:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants