Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup stretch-slim base image to allow installing openjdk #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eighthave
Copy link

The stretch-slim base image removes the man pages, docs, locales, etc. Some package install processes will fail if the dirs are not present, like /usr/share/man/man1. This includes default-jdk-headless, which someone would install if they wanted to run a gradle build in the Docker image before starting the emulator.

The mkdir hack comes from:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199

Here's an example of running a build in this image:
https://gitlab.com/eighthave/ci-images-emulator-kvm/-/jobs/1052060212

The stretch-slim base image removes the man pages, docs, locales, etc. Some
package install processes will fail if the dirs are not present, like
/usr/share/man/man1.  This includes default-jdk-headless, which someone
would install if they wanted to run a gradle build in the Docker image
before starting the emulator.

The mkdir hack comes from:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199
@google-cla
Copy link

google-cla bot commented Feb 24, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pokowaka
Copy link
Collaborator

Would you mind signing the cla? That way we can merge it in

@eighthave
Copy link
Author

@googlebot I signed it!

@eighthave
Copy link
Author

I see you just refactored the Dockerfile template handling. I think it probably makes sense to just include these changes in the Dockerfile templates. I can't figure out which Docker base image it being used now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants