Be more robust in the ShaderView for null resources.

google · Apr 20, 2022 · e408dd8 · e408dd8
1 parent 4426199
commit e408dd8
Showing 1 changed file with 16 additions and 13 deletions.
diff --git a/gapic/src/main/com/google/gapid/views/ShaderView.java b/gapic/src/main/com/google/gapid/views/ShaderView.java
@@ -123,7 +123,7 @@ public static class ShaderWidget extends Composite {
     private final TabFolder tabFolder;
     private final Composite sourceContainer;
     private final Group statGroup;
-    private final TableViewer statTable;
+    protected final TableViewer statTable;
     private final GridData crossCompileGridData;
     private final SourceViewer spirvViewer;
     private final SourceViewer sourceViewer;
@@ -281,19 +281,22 @@ protected void onUiThread(API.Shader result) {
     }
 
     public void setShader(Service.Resource resource, API.Shader shader) {
-      rpcController.start().listen(models.resources.loadResourceExtras(resource),
-          new UiCallback<API.ResourceExtras, API.ShaderExtras>(this, LOG) {
-        @Override
-        protected API.ShaderExtras onRpcThread(Rpc.Result<API.ResourceExtras> result)
-            throws RpcException, ExecutionException {
-          return result.get().getShaderExtras();
-        }
+      if (resource != null) {
+        rpcController.start().listen(models.resources.loadResourceExtras(resource),
+            new UiCallback<API.ResourceExtras, API.ShaderExtras>(this, LOG) {
+          @Override
+          protected API.ShaderExtras onRpcThread(Rpc.Result<API.ResourceExtras> result)
+              throws RpcException, ExecutionException {
+            return result.get().getShaderExtras();
+          }
+
+          @Override
+          protected void onUiThread(API.ShaderExtras result) {
+            statTable.setInput(result.getStaticAnalysis());
+          }
+        });
+      }
 
-        @Override
-        protected void onUiThread(API.ShaderExtras result) {
-          statTable.setInput(result.getStaticAnalysis());
-        }
-      });
       loading.stopLoading();
 
       shaderResource = resource;