Support for the positive scale in xee added. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naschmitz
requested changes
Mar 28, 2024
mahrsee1997
reviewed
Mar 29, 2024
naschmitz
requested changes
Apr 2, 2024
xee/ext.py
Outdated
| x_start, y_start, x_end, y_end = bbox | ||
| width = x_end - x_start | ||
| height = y_end - y_start | ||
|
|
||
| # Found the actual coordinates of the first or last point of the bbox based on the pos & neg scale in the actual image. |
There was a problem hiding this comment.
This comment needs some line-rewrapping. Consider re-writing to capture the weirdness of EE bounding boxes:
Origin (transform translation) cannot be found by simply identifying the min and max extents of the EE bounding box. The bounding boxes can be flipped (negative scale).
naschmitz
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in the title, Xee does not work properly when the positive scale is passed. To address this, I have included a logic that can also operate on the positive scale.
The reference notebook, which includes all possible test cases, can be found here Reference notebook