Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fake for GIDAuthorizationFlowProcessor #287

Open
wants to merge 16 commits into
base: refactorGSI
Choose a base branch
from
Open

Add fake for GIDAuthorizationFlowProcessor #287

wants to merge 16 commits into from
+156 −82

Conversation

Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Jan 11, 2023 •
edited
Loading

  1. Add the class GIDFakeAuthorizationFlowProcessor conforming to the protocol GIDAuthorizationFlowProcessor and use it to replace mock in GIDSignInTest.
  2. Removed one test case testNotHandleWrongScheme because it is testing the AppAuth API.

@Alex-4-Git Alex-4-Git force-pushed the pin-GIDAuthorizationFlowProcessor-fake branch from 687bbd8 to 2d60ea9 Compare January 18, 2023 22:30
@Alex-4-Git Alex-4-Git requested review from mdmathias and petea and removed request for mdmathias January 18, 2023 22:47
@Alex-4-Git Alex-4-Git marked this pull request as ready for review January 18, 2023 22:47
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDAuthorizationFlowProcessor-fake branch from c54f930 to 89649b1 Compare January 18, 2023 22:49
petea
petea reviewed Jan 19, 2023
View reviewed changes
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Show resolved Hide resolved
@Alex-4-Git Alex-4-Git marked this pull request as draft January 20, 2023 00:02
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDAuthorizationFlowProcessor-fake branch from 620ceff to df7f780 Compare January 20, 2023 00:29
@Alex-4-Git Alex-4-Git marked this pull request as ready for review January 20, 2023 00:30
@henryhl22321 henryhl22321 requested review from henryhl22321 and removed request for petea and henryhl22321 May 17, 2023 21:11
henryhl22321 and others added 3 commits May 17, 2023 15:34
@henryhl22321
Uncommented the existing verification line.
0ae1e7f
@mdmathias @henryhl22321
Remove macos-11 runner
0b143d5
@mdmathias @henryhl22321
Update name of return button
21745e4 
The UI automation test previously used 'go' but it appears the button has been renamed to 'return'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryhl22321 henryhl22321 henryhl22321 left review comments

@petea petea petea left review comments

@mdmathias mdmathias Awaiting requested review from mdmathias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alex-4-Git @petea @mdmathias @henryhl22321