ToString Tests #731
Closed
ToString Tests #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not deprecating the |
bgogul
reviewed
Sep 23, 2022
|
@bgogul ready for re-review |
bgogul
approved these changes
Sep 30, 2022
added 10 commits
October 3, 2022 11:35
aferr
force-pushed
the
to-string-tests@aferr
branch
from
d292ac8
to
bbf1048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests to
ast_string.hwhich we apparently already had and already used for other tests in the repository. However, this code didn't have any tests itself. So rather than have two ways of making a string from the AST, I updatedast_string.hso that it is good enough for the uses of the ToString methods in the AST and added some tests forast_string.h. In a follow-up PR, I will deprecate the ToString methods in the AST class and use justast_string.hfor the remaining tests thereby satisfying #720.