auth_logic AST operator== #700

aferr · 2022-09-01T15:58:55Z

No description provided.

aferr · 2022-09-01T15:59:52Z

Fixes #676

aferr · 2022-09-01T16:00:52Z

As a side-effect this also moves the DebugPrint() functions that are longer than 2 lines to a .cc file.

bgogul

Thank you for doing this. I have left A few readability and testing related comments.

src/ir/auth_logic/ast_equality_test.cc

src/ir/auth_logic/ast.cc

src/ir/auth_logic/ast.h

src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc

src/ir/ast_node.h

src/ir/auth_logic/ast.h

src/ir/datalog/program.h

(since we could not deprecate this from ast_visitor_traversing_visitor_test.cc)

bgogul

Looks good. Just some minor nits here and there.

src/ir/auth_logic/ast.h

src/ir/auth_logic/ast_equality_test.cc

src/ir/datalog/program.h

aferr requested a review from bgogul September 1, 2022 15:59

aferr marked this pull request as ready for review September 1, 2022 15:59

bgogul reviewed Sep 1, 2022

View reviewed changes

aferr mentioned this pull request Sep 8, 2022

Universe relations #654

Closed

aferr force-pushed the ast-equality@aferr branch from e6ad304 to f15c8c7 Compare September 12, 2022 11:16

aferr changed the base branch from universe-relations@aferr to main September 12, 2022 11:25

aferr commented Sep 12, 2022

View reviewed changes

src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc Outdated Show resolved Hide resolved

markww reviewed Sep 12, 2022

View reviewed changes

aferr force-pushed the ast-equality@aferr branch from 272bb11 to f15c8c7 Compare September 14, 2022 14:24

aferr requested a review from bgogul September 14, 2022 16:45

aferr added ready to pull and removed ready to pull labels Sep 14, 2022

Andrew Ferraiuolo added 4 commits September 15, 2022 13:01

auth_logic AST operator==

d2c15e0

Adding DebugPrint back

86bca9d

(since we could not deprecate this from ast_visitor_traversing_visitor_test.cc)

Use test pattern

6b0fd3a

PR fixes; linting

3b9ae4d

aferr force-pushed the ast-equality@aferr branch from 0f580ee to 3b9ae4d Compare September 15, 2022 12:31

Add comment to fix pr

0d05d16

bgogul approved these changes Sep 15, 2022

View reviewed changes

aferr force-pushed the ast-equality@aferr branch 2 times, most recently from 173fdb4 to 8aaedfd Compare September 15, 2022 13:19

aferr added the ready to pull label Sep 15, 2022

PR fixup

f7eb278

aferr force-pushed the ast-equality@aferr branch from 8aaedfd to f7eb278 Compare September 15, 2022 13:28

copybara-service bot closed this in 9706fa4 Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

auth_logic AST operator== #700

auth_logic AST operator== #700

aferr commented Sep 1, 2022

aferr commented Sep 1, 2022

aferr commented Sep 1, 2022

bgogul left a comment

bgogul left a comment

auth_logic AST operator== #700

auth_logic AST operator== #700

Conversation

aferr commented Sep 1, 2022

aferr commented Sep 1, 2022

aferr commented Sep 1, 2022

bgogul left a comment

Choose a reason for hiding this comment

bgogul left a comment

Choose a reason for hiding this comment