Update Bazel rules_foreign_cc from 0.4.0 to 0.8.0.

[shaper]

As part of building CVC5 for #622 I found that our rules_foreign_cc library seems quite dated. The new version allows specifying copts in the cmake rule, and there are surely other updates of potential use as well.

[markww]

LGTM, but you need to run buildifier to fix internal checks.

[harsha-mandadi]

This version change has caused my build to fail on Mac with following error.

./lib/findprog-in.c:137:25: error: implicit declaration of function 'eaccess' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                    if (eaccess (progpathname, X_OK) == 0)
                        ^
./lib/findprog-in.c:137:25: note: did you mean 'access'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/unistd.h:431:6: note: 'access' declared here
int      access(const char *, int);
         ^
./lib/findprog-in.c:211:21: error: implicit declaration of function 'eaccess' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                if (eaccess (progpathname, X_OK) == 0)

Looks like error is related to eaccess being called before it is declared. It fails on something not related to raksha. Have you encountered this or is this only for mac users?

[markww]

This looks like a warning that has been upgraded to an error. We should probably just disable -Werror for third party code; I'm surprised it's on in this build in the first place.