Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable syntax highlighting #503

Closed

Conversation

sureyeaah
Copy link

Created portable syntax highlighting using Iro along with a vscode plugin.

Fixes #176

Created portable syntax highlighting using Iro along with a vscode
plugin.

Fixes google-research#176
@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@oxinabox
Copy link
Contributor

oxinabox commented Mar 8, 2021

Apparently the textmate format used here for VS-code is used in a bunch of other editors too.
(TextMate being the most obvious, but also SublimeText and Atom)

Copy link
Collaborator

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please let's avoid checking in generated files to main (especially ones with some default content we don't need like the README, CHANGELOG, etc.)

@sureyeaah
Copy link
Author

Alright, I'll move those to a different branch.

@axch
Copy link
Collaborator

axch commented Sep 9, 2022

Is there any interest in reviving / completing this contribution? If this PR has been abandoned, I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portable regex-based syntax highlighting
4 participants