-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial bugfixes and CI integration #472
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bd1acef
Small change to update syntax and fix indices
srush fb5a33b
Small changes to type classes
srush 1c95ce7
add to CI
srush b4bc3c8
download binary files
srush b8abc1c
update github actions and tutorial download
srush 14554a2
Remove extraneous whitespace.
dan-zheng 6971098
update the tests for new mnist files
srush 71f3d4b
Merge branch 'tutorialfinal' of https://github.com/srush/dex-lang int…
srush fe862c4
Fix errors in tutorial
srush 7efdbd2
Merge branch 'main' into tutorialfinal
srush 5e9bab4
update to fashion mnist
srush 7e87f4c
Merge branch 'tutorialfinal' of https://github.com/srush/dex-lang int…
srush 438038b
Merge branch 'main' into tutorialfinal
srush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't
unzip
a bit more standard for this? I think it's equivalent to gunzip on most Linuxes, but also works on BSD-based systems (macOS).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is that true?
unzip
doesn't seem to work for me linux for .gz files. Alsogunzip
seems to install fine in the macOS CI test. But I don't have a mac to test on. Does unzip work there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm the following works on macOS:
Hope this helps!