Pretty-print n => Char tables as string literals.
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
force-pushed
the
print-string-literals
branch
from
2340983 to
9ddd1f5
Compare
apaszke
approved these changes
Dec 10, 2020
|
This needs a rebase now. @dougalm this is going to conflict with your PR. What order should we merge those in? |
dan-zheng
force-pushed
the
print-string-literals
branch
from
9ddd1f5 to
29c6c80
Compare
Make `prettyVal` print `n=>Char` tables as string literals. Add `make update-all` command for updating all test files. Update tests.
dan-zheng
force-pushed
the
print-string-literals
branch
from
2e25404 to
41c0d5c
Compare
dan-zheng
commented
Dec 12, 2020
| return $ pretty elems <> idxSetStr | ||
| atom <- evalBlock mempty $ snd $ applyAbs abs idx | ||
| case atom of | ||
| Con (Lit (Word8Lit c)) -> |
There was a problem hiding this comment.
Note: #315 removed the pattern CharLit c, so the replacement is now Con (Lit (Word8Lit c)).
Could we add a new abbreviated pattern for this, while being future-facing for potential Unicode support? I wonder what would be a good name.
| let bodyType = getType body | ||
| let elemsDoc = case bodyType of | ||
| -- Print table of characters as a string literal. | ||
| TC (BaseType (Scalar Word8Type)) -> pretty ('"': concat elems ++ "\"") |
There was a problem hiding this comment.
Note: #315 removed the pattern CharType, so the replacement is now TC (BaseType (Scalar Word8Type)).
Could we add a new abbreviated pattern for this, while being future-facing for potential Unicode support? I wonder what would be a good name.
apaszke
approved these changes
Dec 15, 2020
|
Thanks, Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
prettyValprintn => Chartables as string literals.Add
make update-allcommand for updating all test files. Update tests.Resolves #321.
Depends on #327, which should be reviewed and merged first.
Examples: