Define ordering and equality on Char #306
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
src/lib/Type.hs
Outdated
| @@ -728,6 +728,9 @@ typeCheckOp op = case op of | |||
| i |: TC (IntRange (IdxRepVal 0) (IdxRepVal $ fromIntegral vectorWidth)) | |||
| return $ BaseTy $ Scalar sb | |||
| ThrowError ty -> ty|:TyKind $> ty | |||
| -- TODO: type check that c is a character | |||
| -- TODO: this should really be a 32 bit integer for unicode reasons: 8 bit is just 1 codeunit | |||
| CodePoint c -> return $ BaseTy $ Scalar Int8Type | |||
There was a problem hiding this comment.
Presumably there is more checking i should do to make sure the c is a character not some other type?
I don't know how though.
Right now i get an error that crashes the repl if i try to do nonsense
>=> %codePoint 1
dex: src/lib/Imp.hs:(194,27)-(275,2): Non-exhaustive patterns in Con (CharCon x)
There was a problem hiding this comment.
Yes, the check would be something like c |: CharTy. But you might still get a compiler error, just an earlier one, if you write %codePoint 1. The %-prefixed names are supposed to be wrapped in the prelude and not used directly.
There was a problem hiding this comment.
What does c |: CharTy do?
There was a problem hiding this comment.
Yep, now we get a better error that doesn't crash the REPL
>=> %codePoint 'a'
97
>=> %codePoint 1
Compiler bug!
Please report this at github.com/google-research/dex-lang/issues
assertion failure ():
Char != Int32
checking decl:
tmp:Int8 = %codePoint 1
Checking body types
Checking module:
Module (Typed)
unevaluated decls:
tmp:Int8 = %codePoint 1
tmp1:Int8 = tmp
_ans_:Int8 = tmp1
evaluated bindings:
()
Though still i guess not great since it says it is a compiler bug.
But still noone should use %codePoint directly anyway, we have codepoint in the prelude for that, as you say.
|
I think I have confused the bot a lot. |
src/lib/Type.hs
Outdated
| @@ -728,6 +728,9 @@ typeCheckOp op = case op of | |||
| i |: TC (IntRange (IdxRepVal 0) (IdxRepVal $ fromIntegral vectorWidth)) | |||
| return $ BaseTy $ Scalar sb | |||
| ThrowError ty -> ty|:TyKind $> ty | |||
| -- TODO: type check that c is a character | |||
| -- TODO: this should really be a 32 bit integer for unicode reasons: 8 bit is just 1 codeunit | |||
| CodePoint c -> return $ BaseTy $ Scalar Int8Type | |||
There was a problem hiding this comment.
Yes, the check would be something like c |: CharTy. But you might still get a compiler error, just an earlier one, if you write %codePoint 1. The %-prefixed names are supposed to be wrapped in the prelude and not used directly.
This closes #301
It defines a built in operation
codepointthat should return the ASCII code point.Ideally it would return the unicode codepoint, but we are a fair way from unicode support, see #302.
So rright now for characters outside the ASCII character set it returns nonsense.