Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the test constructor to allow injecting an http engine to allo… #211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

change the test constructor to allow injecting an http engine to allo… #211

wants to merge 2 commits into from

Conversation

davidmotson
Copy link
Collaborator

…w more configuration of the mockengine

@davidmotson davidmotson requested a review from rlazo July 23, 2024 16:34
@tanzimfh
Copy link
Collaborator

I don't think the test constructor is needed anymore. Reverting fa9688a should achieve what you're looking for.

@davidmotson
Copy link
Collaborator Author

I don't think the test constructor is needed anymore. Reverting fa9688a should achieve what you're looking for.

I don't think that's sufficient, the public constructor does not allow me to pass an http engine, that constructor is internal only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlazo rlazo Awaiting requested review from rlazo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmotson @tanzimfh