Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification for transforms with empty state #895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabianp
Copy link
Member

@fabianp fabianp commented Mar 28, 2024

No description provided.

@fabianp fabianp requested a review from vroulet March 28, 2024 08:24
Copy link
Collaborator

@vroulet vroulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!
Some comments:

  • one may remove all corresponding states from the docs
  • I think you may remove ScaleState (and modify scale(...))

I don't know why the tests are not finishing though...
I can see that test_centralize has a weird update(inputs, {}) might need to be update(inputs, base.EmptyState())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants