Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split github workflows for lower latency, add ruff #1156

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Split github workflows for lower latency, add ruff #1156

merged 1 commit into from
Dec 11, 2024
+84 −8

Conversation

rdyro
Copy link
Collaborator

@rdyro rdyro commented Dec 10, 2024 •
edited
Loading

This PR

  • splits linting and doctests from the combined test.sh to provide a faster workflow iteration
    • without removing that action from test.sh
    • in the future this duplication can be removed
  • adds ruff check . for fast linting check (currently in addition to pylint)
  • build-and-test and doctests workflows now also depend on the linting success

@rdyro rdyro requested review from fabianp and vroulet December 10, 2024 21:17
fabianp
fabianp approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Robert!

@copybara-service copybara-service bot merged commit 78fe20e into main Dec 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianp fabianp fabianp approved these changes

@vroulet vroulet Awaiting requested review from vroulet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdyro @fabianp