Fix: phantom tic-tac-toe and dark hex information state when obs type is reveal nothing #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 👍 Can you regenerate the playthroughs and add the updated playthrough files too? Otherwise the playthrough test will fail. You can use this script: https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/scripts/regenerate_playthroughs.sh |
|
There we go :) Tests run successfully locally for me. |
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273 and #1274.
The info state size for pttt and dh is now smaller when the obs type is reveal-nothing. In this case, instead of storing at most 17 moves of 11 bits each, we only store at most 9 moves (no opponent moves) of 9 bits each (removed info about the player and the "unknown" move).