Adding game TwixT

[stevens68]

TwixT is a 2-player, deterministic, perfect information game, played on a 24x24 grid. See Wikipedia. This PR adds it to open_spiel. The board size can be adjusted from 5x5 to 24x24

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[lanctot]

Awesome, thanks! We'll take a look soon.

[lanctot]

Thanks for the game!

I have a few comments about style before we take a look at the logic.

I will point out a few things, and the reference is the Google C++ style guide. The C++ code style should be consistent with the rest of the games; you can look at them for reference. For more detail, see this: https://google.github.io/styleguide/cppguide.html

[stevens68]

Thanks for your quick feedback, lanctot! I will apply the guidelines, add tests and do some simplifications.
Will push the changes within the next 2 weeks.

[lanctot]

Thanks for your quick feedback, lanctot! I will apply the guidelines, add tests and do some simplifications. Will push the changes within the next 2 weeks.

Great, thanks. I will be away for 10 days as of today so there will be a delay on my end. Please reply to (and resolve) each of the comments when they are done.

[lanctot]

Hi @stevens68, I will take a look over the holidays. Thanks!

[lanctot]

Hi @stevens68, time got away from me. Could you pull and merge changes from master to resolve the conflicts, and then push the merge commit to your branch?

[stevens68]

Hi @stevens68, time got away from me. Could you pull and merge changes from master to resolve the conflicts, and then push the merge commit to your branch?

Hi @lanctot, thanks for looking into it! Merged the changes and resolved the conflicts.

[lanctot]

@stevens68, it's been merged and should be included in the next sync to github (probably Monday) and included in the list of additions in the next release. Sorry for the long delay!

BTW, I was delighted to see the ANSI graphics in the ToString, nicely done! 🥰 👍

[pilot68]

...thx for your reviewing efforts and comments. I learned a lot! take care!