Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop run #197

Merged
merged 15 commits into from
May 7, 2021
Merged

Drop run #197

merged 15 commits into from
May 7, 2021

Conversation

goodboy
Copy link
Owner

@goodboy goodboy commented Feb 24, 2021

This should start resolving the following:

@goodboy
Copy link
Owner Author

goodboy commented Feb 25, 2021

Lol of course multiprocessing hangs now 😂

I was able to reproduce if you run:
pytest tests/test_discovery.py tests/test_cancellation.py --spawn-backend='mp'

Seems like some poll hang on shutdown...

^CError in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/popen_fork.py", line 27, in poll
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
    pid, sts = os.waitpid(self.pid, flag)
KeyboardInterrupt
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
  File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
  File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
  File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
  File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
  File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
  File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'

Might have to delay the full tractor.run() removal to just get a gd .dev0 out 😂

@goodboy
Copy link
Owner Author

goodboy commented Apr 28, 2021

Gonna try rebasing this onto #206 to see if we lose wtv race conditions were making mp 🤮

@goodboy goodboy force-pushed the drop_run branch 2 times, most recently from b5df6f2 to 3de2e9e Compare April 29, 2021 02:20
@goodboy goodboy changed the base branch from master to mp_teardown_hardening April 29, 2021 02:23
Base automatically changed from mp_teardown_hardening to master May 6, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant