Ss shadow pass pr selection

[lyonsno]

Add selective option

The new 'selects' parameter should be an array of objects to which the effect will be applied. If an array is passed in the effect will only apply to objects contained in the array.

[lyonsno]

@gonnavis I'm thinking of adding a GUI element to the example demonstrating this feature, what do you think?

[gonnavis]

Add selective option

The new 'selects' parameter should be an array of objects to which the effect will be applied. If an array is passed in the effect will only apply to objects contained in the array.

Thanks! Works very well.

PS: test link: https://raw.githack.com/lyonsno/three.js/SSShadowPassPr-selection/examples/webgl_postprocessing_ssshadow.html

[gonnavis]

@gonnavis I'm thinking of adding a GUI element to the example demonstrating this feature, what do you think?

What GUI element do you mean?
Not this?

[lyonsno]

Thanks! Works very well.

Thank you! The way it works currently, non-selected objects will still cast, but not receive the effect. I hope this is proper behavior because removing them as casters would be trickier.

PS: test link: https://raw.githack.com/lyonsno/three.js/SSShadowPassPr->selection/examples/webgl_postprocessing_ssshadow.html

I should include this in PRs right? How should I modify the example to demonstrate an effect like this? This kind of brings me to the question below:

@gonnavis I'm thinking of adding a GUI element to the example demonstrating this feature, what do you think?

What GUI element do you mean? Not this?

I meant a toggle to turn the effect on/off for certain elements to demonstrate. Not sure if this feature is important enough that that's necessary though. The SSR example doesn't have a GUI for it I don't think.

--

Next I'm actually pumped to start thinking about refraction, it's a tricky problem. Have you done any brainstorming on it?

[gonnavis]

PS: test link: https://raw.githack.com/lyonsno/three.js/SSShadowPassPr-selection/examples/webgl_postprocessing_ssshadow.html

I should include this in PRs right? How should I modify the example to demonstrate an effect like this?

It's a link generated by raw.git ( or brower extension ), just for easy testing.
You can keep committing to your SSShadowPassPr-selection branch and it'll auto update after about 20 minutes.

I meant a toggle to turn the effect on/off for certain elements to demonstrate. Not sure if this feature is important enough that that's necessary though. The SSR example doesn't have a GUI for it I don't think.

I think you can either put the toggle in GUI like this https://raw.githack.com/gonnavis/three.js/SSRPassSupportDifferentMetalnessPr/examples/webgl_postprocessing_ssr.html

Or by click the objects directly like this https://raw.githack.com/gonnavis/three.js/SSRrPassPr/examples/webgl_postprocessing_ssrr.html

Next I'm actually pumped to start thinking about refraction, it's a tricky problem. Have you done any brainstorming on it?

I've already did it mrdoob#21420
But currently prefer to use transmission mrdoob#23569

[lyonsno]

I've already did it mrdoob#21420
But currently prefer to use transmission mrdoob#23569

Ah I see. What about meshBasicMaterial objects like the ones used in the example? When their opacity is set to < 1, right now the SSShadows aren't visible through them. Do you think that should be fixed? It might not be worth the extra pass it would probably take, I'm not sure.

[gonnavis]

When their opacity is set to < 1, right now the SSShadows aren't visible through them. Do you think that should be fixed? It might not be worth the extra pass it would probably take, I'm not sure.

That's the hard part. When doing SSRrPass, I faced the same problem.

I render BeautyPass first, then SSRrPass which based on RefractivePass. Thus I can make such as box and bunny be transparent ( opacity < 1 ).
I've already added more Passes in the above process, but still can't see the bunny through the box.
If want to achieve this effect, I feel must add extra pass to each transparent object separately.

[gonnavis]

For SSShadow, maybe ignore transparent/opacity, just do opaque first.

[lyonsno]

For SSShadow, maybe ignore transparent/opacity, just do opaque first.

Sorry I had to drop this for a bit. In that case it should be pretty much ready to merge after I add the feature to the example GUI right?

[gonnavis]

Yes, I tested that the selects works fine and very happy to merge, thanks!

But by the way, I don't know if you intentionally submit PR to my fork repo https://github.com/gonnavis/three.js , instead of Mr.Doob's official repo https://github.com/mrdoob/three.js.
So even I merged, your codes will just go into the commits list of my PR mrdoob#21951 , and we'll still need to go through strictly checking and need to handle reviews if any.

[lyonsno]

That's awesome! I'm a little new to working with nested github forks, how could I submit this as a PR to the official repo without all of your changes included?

…

On Thu, May 12, 2022 at 6:14 AM Vis ***@***.***> wrote: Yes, I tested that the selects works fine and very happy to merge, thanks! But by the way, I don't know if you intentionally submit PR to my fork repo https://github.com/gonnavis/three.js , instead of Mr.Doob's official repo https://github.com/mrdoob/three.js. So even I merged, your codes will just go into the commits list of my PR mrdoob#21951 <mrdoob#21951> , and we'll still need to go through strictly checking and need to handle reviews if any. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFN2ZG3R245FAYPVMH5RADVJT75HANCNFSM5UNMG6LA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[gonnavis]

@lyonsno You can make a fresh new PR to https://github.com/mrdoob/three.js directly.