Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow and use newest upload-artifact action #15

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Sep 24, 2024

  • Fix commands that had errors during merge conflict resolution
  • Update build/release workflow to work with v4 of upload-artifact

Fix error introduced during merge conflict resolution:
- Use --sysbuild in the build command
- Start in the build directory when archiving artifacts

Signed-off-by: Mike Szczys <[email protected]>
The new version of upload artifact disallows repeat upload to the same
directory. Instead, artifacts should be uploaded using unique names, then
gathered into a single archive using the merge and pattern parameters.

- Split board name into its own step
- Use board name for build, artifact names, and upload archive name

Signed-off-by: Mike Szczys <[email protected]>
Copy link
Contributor

@MarkoPura MarkoPura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szczys szczys merged commit c67ad7f into main Oct 2, 2024
7 checks passed
@szczys szczys deleted the szczys/fix-release-build-command branch October 2, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants