hil: ota: use 1 Hz polling for reason and state test #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit b8ac3d4): https://golioth-firmware-sdk-doxygen-dev--pr674-szczys-hil-ota-ey58gdtb.web.app (expires Mon, 25 Nov 2024 04:26:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Use 1 Hz polling in pytest to catch reason and state changes more efficiently. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/hil-ota-use-polling
branch
from
f520e10
to
b8ac3d4
Compare
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
Changes look good! Can we run the test a few times to see how stable it is? |
I ran the entire suite twice (once with original PR and once last night on a force-push) and it passed both times. I ran the nsim-integration and linux-integration just now and those passed as well. |
sam-golioth
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 1 Hz polling in pytest to catch reason and state changes more efficiently.
This removes an arbitrary delay, instead trying multiple times to get the device's reported reason and state codes. On the final timeout, the asserts will always be run so we retain helpful logging messages. This PR also reduces the device delay by 3 seconds, which equates to 30 seconds saved across all reason codes.