Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hil: zephyr: increase log buffer to prevent dropped logs #673

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Nov 15, 2024

When running the settings HIL test for Zephyr, logs are often dropped because of the number of settings being reported on first connect. This often results in the "Connected" message being dropped which causes the test to fail.

Double the size of the Zephyr log buffer to 2048 to prevent logs from being dropped.

When running the settings HIL test for Zephyr, logs are often dropped
because of the number of settings being reported on first connect. This
often results in the "Connected" message being dropped which causes the
test to fail.

Double the size of the Zephyr log buffer to 2048 to prevent logs from being
dropped.

Signed-off-by: Mike Szczys <[email protected]>
Copy link

Visit the preview URL for this PR (updated for commit adbc87b):

https://golioth-firmware-sdk-doxygen-dev--pr673-szczys-hil-set-vcyc6oos.web.app

(expires Fri, 22 Nov 2024 21:49:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

Copy link

Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
include.golioth 75% 50%
port.linux 53% 28%
port.zephyr 51% 21%
src 69% 32%
Summary 67% (2506 / 3728) 31% (1075 / 3451)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

@szczys szczys merged commit 06b8230 into main Nov 18, 2024
64 of 76 checks passed
@szczys szczys deleted the szczys/hil-settings-bump-log-buffer branch November 18, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants