OCT-2193 Implement language selector: app #561
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikolajczyk
requested changes
Nov 29, 2024
| &.variant-- { | ||
| &overselect, &underselect { |
There was a problem hiding this comment.
underselect to remove
There was a problem hiding this comment.
I don't see the reason. Why?
| const LanguageSelector = (): ReactElement => { | ||
| const { t, i18n } = useTranslation('translation'); | ||
|
|
||
| const languageOptions = getLanguageOptions(t); |
There was a problem hiding this comment.
I think getLanguageOptions as an additional layer is unnecessary here.
| <div className={styles.newsletterAndLanguageSelector}> | ||
| <div className={styles.newsletterWrapper}> | ||
| <div ref={newsletterRef} className={styles.newsletter} /> | ||
| <div className={styles.newsletterText}>{t('newsletterText')}</div> |
There was a problem hiding this comment.
Duplication of newsletterText.
| @@ -22,9 +23,15 @@ import { octantSemiTransparent } from 'svg/logo'; | |||
| import styles from './LayoutFooter.module.scss'; | |||
| import LayoutFooterProps from './types'; | |||
|
|
|||
| const LanguageSelectorWrapped = (): ReactElement => ( | |||
There was a problem hiding this comment.
I suggest one component per file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done
(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.
(2) Octant Areas & Test Cases.