Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-2154: update automated api e2e tests after migration to fastapi #554

Conversation

adam-gf
Copy link
Contributor

@adam-gf adam-gf commented Nov 14, 2024

Description

Adding tests of fastapi routes for allocation and project rewards

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@adam-gf adam-gf self-assigned this Nov 14, 2024
Copy link

linear bot commented Nov 14, 2024

@adam-gf adam-gf changed the base branch from develop to fast-migration-allocations November 29, 2024 08:53
…utomated-api-e2e-tests-after-migration-to-fastapi
@adam-gf adam-gf merged commit 1c895c7 into fast-migration-allocations Dec 2, 2024
31 checks passed
@adam-gf adam-gf deleted the adam/oct-2154-update-automated-api-e2e-tests-after-migration-to-fastapi branch December 2, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant