OCT-1643: Teardown session after request finished #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My hypothesis is that the database scoped-sessions (that are implicitly created for each flask request) aren't closed properly. It results in the need for creating additional database connections to handle these "idle" sessions and then it makes the overflow. The idea is to make sure that we do
db.session.remove()
when every request is retrieved in our Flask application (as it comes out from SO threads and documentation, it doesn't happen automatically)Definition of Done
(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.
(2) Octant Areas & Test Cases.