Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1643: Teardown session after request finished #219

Merged
merged 2 commits into from
May 20, 2024

Conversation

kgarbacinski
Copy link
Contributor

@kgarbacinski kgarbacinski commented May 16, 2024

Description

My hypothesis is that the database scoped-sessions (that are implicitly created for each flask request) aren't closed properly. It results in the need for creating additional database connections to handle these "idle" sessions and then it makes the overflow. The idea is to make sure that we do db.session.remove() when every request is retrieved in our Flask application (as it comes out from SO threads and documentation, it doesn't happen automatically)

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski self-assigned this May 16, 2024
@kgarbacinski kgarbacinski force-pushed the fix/oct-1643-handle-524-error branch from 9cfd7ec to 95af7bb Compare May 16, 2024 13:29
@kgarbacinski kgarbacinski force-pushed the fix/oct-1643-handle-524-error branch from 95af7bb to aa454c6 Compare May 16, 2024 13:49
@housekeeper-bot housekeeper-bot temporarily deployed to uat May 16, 2024 14:57 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat May 16, 2024 15:17 Destroyed
@kgarbacinski
Copy link
Contributor Author

/deploy

@housekeeper-bot housekeeper-bot temporarily deployed to uat May 16, 2024 15:48 Destroyed
@kgarbacinski kgarbacinski requested a review from leoni-q May 16, 2024 21:55
@kgarbacinski kgarbacinski merged commit 60fc98a into develop May 20, 2024
64 of 66 checks passed
@kgarbacinski kgarbacinski deleted the fix/oct-1643-handle-524-error branch May 20, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants