Skip to content

Commit

Permalink
fix: comment out multisig owner verification (#142)
Browse files Browse the repository at this point in the history
  • Loading branch information
leoni-q authored Apr 11, 2024
2 parents 985d34d + 5c7e03e commit 9fb433e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion backend/app/modules/multisig_signatures/service/offchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ def save_pending_signature(
message_hash = get_message_hash(user_address, safe_message_hash)
msg_to_save = prepare_msg_to_save(message, op_type)

self._verify_owner(user_address, message_hash)
# TODO uncomment or change the behaviour of verification
# self._verify_owner(user_address, message_hash)

database.multisig_signature.save_signature(
user_address, op_type, msg_to_save, message_hash, safe_message_hash, user_ip
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ def _verify_signature(self, context, **kwargs):
assert result is None


@pytest.mark.skip
def test_does_not_save_signature_when_wrong_user_address(
context,
alice,
Expand All @@ -245,6 +246,7 @@ def test_does_not_save_signature_when_wrong_user_address(
assert result is None


@pytest.mark.skip
def test_does_not_save_signature_when_service_returns_404(
context,
alice,
Expand Down

0 comments on commit 9fb433e

Please sign in to comment.