Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use serde_bytes for GsbHttpProxy Message and Response #3339

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Use serde_bytes for GsbHttpProxy Message and Response #3339

merged 1 commit into from
Oct 3, 2024

Conversation

mwalkiewicz
Copy link
Collaborator

@mwalkiewicz mwalkiewicz commented Oct 3, 2024 •
edited by nieznanysprawiciel
Loading

@mwalkiewicz mwalkiewicz requested a review from a team as a code owner October 3, 2024 10:52
@mwalkiewicz mwalkiewicz force-pushed the mw/gsb-http-proxy-serde-bytes/1 branch from 2dbcc79 to f3d0e86 Compare October 3, 2024 11:02
nieznanysprawiciel
nieznanysprawiciel reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add serde_bytes to streaming messages as well

@mwalkiewicz mwalkiewicz force-pushed the mw/gsb-http-proxy-serde-bytes/1 branch from f3d0e86 to d0ccc5c Compare October 3, 2024 11:21
@mwalkiewicz mwalkiewicz merged commit 7f6a3ae into gamerhash/master Oct 3, 2024
35 checks passed
@mwalkiewicz mwalkiewicz deleted the mw/gsb-http-proxy-serde-bytes/1 branch October 3, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nieznanysprawiciel nieznanysprawiciel nieznanysprawiciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwalkiewicz @nieznanysprawiciel