Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rinkeby & zksync #631

Merged
merged 17 commits into from
Sep 20, 2023
Merged

remove rinkeby & zksync #631

merged 17 commits into from
Sep 20, 2023

Conversation

kamirr
Copy link
Contributor

@kamirr kamirr commented Aug 30, 2023

No description provided.

@kamirr kamirr linked an issue Aug 30, 2023 that may be closed by this pull request
@kamirr kamirr mentioned this pull request Sep 1, 2023
Both networks are unsupported. Use Goerli instead.
This docker image is responsible for running a Ganache node used for
Goth tests. The previously used version didn't support type 2
transactions.
@scx1332 scx1332 self-requested a review September 18, 2023 15:38
Reruns caused logs to merge improperly, this will separate log files for
each re-run.
@kamirr kamirr linked an issue Sep 19, 2023 that may be closed by this pull request
1 task
@kamirr kamirr requested a review from scx1332 September 20, 2023 07:52
@scx1332 scx1332 merged commit 3da302f into master Sep 20, 2023
3 checks passed
@scx1332 scx1332 deleted the kek/remove-rinkeby branch September 21, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix merged logs when goth tests are re-ran Enable and check tests on payments-dev
2 participants