Disable serde-arbitrary-precision feature of rust-decimal #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which enabled the arbitrary-precision feature of serde-json, which broke yagna. This is because gsb-api relies on json integers being serialized as flexbuffer numbers, while arbitrary-precision makes them serialize as serde-json-specific structures. This cannot be sensibly worked around, because cargo assumes crate features are strictly additive and one cannot depend on the same library twice with the only difference being the set of enabled features. rust-decimal Decimals were only serialized in informational messages which do not affect the correctness of the driver, so this change does not affect any financial computations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which enabled the arbitrary-precision feature of serde-json, which broke yagna. This is because gsb-api relies on json integers being serialized as flexbuffer numbers, while arbitrary-precision makes them serialize as serde-json-specific structures. Besides that if we ever use numbers in the REST API we would obviously serialize them in a way unusable from JS/Python.
This cannot be sensibly worked around, because cargo assumes crate features are strictly additive and one cannot depend on the same library twice with the only difference being the set of enabled features.
rust-decimal Decimals were only serialized in informational messages which do not affect the correctness of the driver, so this change does not affect any financial computations.