Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

App manifest and stubgen cleanups #105

Merged
merged 6 commits into from
Dec 5, 2024
Merged

App manifest and stubgen cleanups #105

merged 6 commits into from
Dec 5, 2024

Conversation

noise64
Copy link
Contributor

@noise64 noise64 commented Dec 5, 2024 •
edited
Loading

  • code and message renames, cleanups
  • deprecation warnings
  • remaining command changes
  • finish custom command handling

@noise64 noise64 mentioned this pull request Dec 5, 2024
Merged
vigoo
vigoo reviewed Dec 5, 2024
View reviewed changes
wasm-rpc-stubgen/src/lib.rs
@@ -43,22 +47,23 @@ test_r::enable!();
#[derive(Parser, Debug)]
#[command(name = "wasm-rpc-stubgen", version)]
pub enum Command {
/// Generate a Rust RPC stub crate for a WASM component
/// [DEPRECATED] Generate a Rust RPC stub crate for a WASM component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also mark these cases with #[deprecated] although never tried

Copy link
Contributor Author

@noise64 noise64 Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't want to make warns / clippy sad, but will check it next time

@noise64 noise64 merged commit b45826c into main Dec 5, 2024
3 checks passed
@noise64 noise64 deleted the stubgen-cleanups branch December 5, 2024 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vigoo vigoo vigoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noise64 @vigoo